[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Custom formats in date/time dialogs
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-09-19 18:43:45
[Download RAW message or body]

On Friday 19 September 2003 09:45, Thomas Zander wrote:
> On Thursday 18 September 2003 23:24, Nicolas Goutte wrote:
> > The attached patch is for koffice/lib/kotext.
> >
> > It allows again to make custom format in the date or time dialogs.
> > (Problem was that combobox was used as a list and not as an editable
> > combobox.)
>
> Don't use an editable combobox here.  They are not usable for this purpose.
> Since you are working on this dialog; would you like me to make a UI file
> for the dialog, since many other small things are not quite nice.

Well, I do not want to make a UI that we will need to drop in KoText 1.4. (Why 
are fixed and variable date variable inserted with a dialog? But creation, 
modification and print date are not (and therefore have not any custom 
formats.))

And if you would want not to use the editable combo box, what do you propose 
instead?

(Good the UI could perhaps be better, but that is too late for KOffice 1.3.)

>
> This line: (end of QString DateFormatWidget::resultString())
> +    return "yyyy-MM-dd"; // Something is wrong, give back a default
> seems wrong; you want to get the locale default and return that; don't
> hardcode locale dependent variables.

This should never appear! But a user will probably more bug us when he sees 
yyy-MM-dd than if he sees a QStrfing::null. (Because he will oversee the 
QString::null as non-implemented, which is not the case here. If it shows 
there is a bug somwhere!)

>
>
> ps. does Word or OpenOffice do times in seconds? It seems totally
> inapropriate for a word processor to me.

Do you mean the format hh:mm:ss? Yes it is the default in OOWriter.

Have a nice day!

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]