[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [PATCH] KoText date/time format history
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-09-18 18:37:07
[Download RAW message or body]

The attached patch is for the file koffice/lib/kotext/kovariable.cc

It fixes the format history of date or time variables by not shoeing the 
locale date/time formats. (This is bug#64474)

The change abaout the variable selectLast are because I misunderstood what the 
variable emant. However, I have still not understood what behaviour is 
intended with this variable. (Why select the last format only if the locale 
format is the first in history? Sorry, but I cannot find any reason why.)

Have a nice day!
["patch_kotext_history.diff" (text/x-diff)]

Index: kovariable.cc
===================================================================
RCS file: /home/kde/koffice/lib/kotext/kovariable.cc,v
retrieving revision 1.126
diff -u -r1.126 kovariable.cc
--- kovariable.cc	29 Aug 2003 13:13:33 -0000	1.126
+++ kovariable.cc	18 Sep 2003 18:31:01 -0000
@@ -972,17 +972,19 @@
             QString num, tmpString;
             num.setNum(i);
             tmpString=config->readEntry("Last Used"+num);
-            if(tmpString.compare(i18n("Locale"))==0)
+            if(tmpString.startsWith("locale"))
             {
-                if(i==0) selectLast = true;
+                if (i==0)
+                    selectLast = true; // ###: what is that supposed to be good for?
                 continue;
             }
-            if(stringList.contains(tmpString))
+            else if(stringList.contains(tmpString))
                 continue;
-            if(!tmpString.isEmpty())
+            else if(!tmpString.isEmpty())
             {
                 stringList.append(tmpString);
                 count++;
+
             }
         }
 
@@ -1138,14 +1140,15 @@
             QString num, tmpString;
             num.setNum(i);
             tmpString=config->readEntry("Last Used"+num);
-            if(tmpString.compare(i18n("Locale"))==0)
+            if(tmpString=="locale")
             {
-                if(i==0) selectLast = true;
+                if (i==0)
+                    selectLast = true; // ###: what is that supposed to be good for?
                 continue;
             }
-            if(stringList.contains(tmpString))
+            else if(stringList.contains(tmpString))
                 continue;
-            if(!tmpString.isEmpty())
+            else if(!tmpString.isEmpty())
             {
                 stringList.append(tmpString);
                 count++;


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]