[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Author info in kofficerc
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-12-18 16:04:10
[Download RAW message or body]

Anyone disagree that we should _not_ save the author info which is also
set in KDE globel in the kofficerc ?

In short;
when I change my settings in kcontrol I also have to change them in koffice 
by opening the document-info dialog and manually changing them there. 
I don't think that we should save the email/full name/company in koffice 
since I hate duplicate info management :)

The patch:

RCS file: /home/kde/koffice/lib/kofficecore/koDocumentInfo.cc,v
retrieving revision 1.9
diff -u -3 -p -d -r1.9 koDocumentInfo.cc
--- koDocumentInfo.cc   2001/11/09 23:43:47     1.9
+++ koDocumentInfo.cc   2001/12/18 16:03:51
@@ -203,9 +203,6 @@ void KoDocumentInfoAuthor::initParameter
     if( config.hasGroup( "Author" ))
     {
         config.setGroup( "Author" );
-        m_fullName=config.readEntry("full-name","");
-        m_company=config.readEntry("company", "");
-        m_email=config.readEntry("email", "");
         m_telephone=config.readEntry("telephone", "");
         m_fax=config.readEntry("fax", "");
         m_country=config.readEntry("country", "");
Index: koDocumentInfoDlg.cc
===================================================================
RCS file: /home/kde/koffice/lib/kofficecore/koDocumentInfoDlg.cc,v
retrieving revision 1.20
diff -u -3 -p -d -r1.20 koDocumentInfoDlg.cc
--- koDocumentInfoDlg.cc        2001/12/02 01:35:05     1.20
+++ koDocumentInfoDlg.cc        2001/12/18 16:03:51
@@ -154,6 +154,13 @@ void KoDocumentInfoDlg::addAuthorPage( K
   (void) new QLabel( i18n( "Company :" ), grid );
   d->m_leCompany = new QLineEdit( authorInfo->company(), grid );

+  if ( authorInfo->company().isEmpty() )
+  {
+    QString name = d->m_emailCfg->readEntry( "Organization" );
+    if ( !name.isEmpty() )
+      d->m_leCompany->setText( name );
+  }
+
   (void) new QLabel( i18n( "EMail :" ), grid );
   d->m_leEmail = new QLineEdit( authorInfo->email(), grid );

@@ -262,9 +273,6 @@ void KoDocumentInfoDlg::save( KoDocument

   KConfig config("kofficerc");
   config.setGroup( "Author" );
-  config.writeEntry("full-name",d->m_leFullName->text());
-  config.writeEntry("company",d->m_leCompany->text() );
-  config.writeEntry("email", d->m_leEmail->text());
   config.writeEntry("telephone", d->m_leTelephone->text());
   config.writeEntry("fax", d->m_leFax->text());
   config.writeEntry("country",d->m_leCountry->text());


-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]