[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] add page on loading
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-12-12 10:03:57
[Download RAW message or body]

On Wed, Dec 12, 2001 at 10:48:03AM +0100, David Faure wrote:
> On Wednesday 12 December 2001 01:02, Thomas Zander wrote:
> > Bug:
> > Opening a multipage-DTP document (from the page-layout tab) did not create the
> > right amount of pages. It always opens at 1 page.
> 
> Huh :(
> 
> > This close to the release of KOffice 1.1.1, could someone please post-commit check 
> > this patch as I have to go to sleep now...
> 
> This close ? You mean _after_ ? :((
> The tarballs are already done, and the binary packages have started to arrive.

Hmm? When did you do that? Last email I saw on this subject is the Laurent 
asked you to wait till end of this week so he could stabilize kchart...
And I saw lots of commits in the branch..
Sorry for the late commit, I simply did not have time to fix it earlier, I spotted
the problem some time ago; should have made a bugreport methinks. :(

> > Index: kwdoc.cc
> > ===================================================================
> > RCS file: /home/kde/koffice/kword/kwdoc.cc,v
> > retrieving revision 1.263.2.4
> > diff -u -3 -p -d -r1.263.2.4 kwdoc.cc
> > --- kwdoc.cc    2001/12/05 23:41:53     1.263.2.4
> > +++ kwdoc.cc    2001/12/12 00:01:16
> > @@ -634,7 +634,19 @@ void KWDocument::recalcFrames()
> >                  }
> >              }
> >          }
> > -
> > +    } else {
> > +        double height=0;
> > +        for (QListIterator<KWFrameSet> fit = framesetsIterator(); fit.current() ; ++fit ) {
> > +            if(fit.current()->frameSetInfo()==KWFrameSet::FI_BODY) {
> > +                KWFrameSet * fs = fit.current();
> > +                for (QListIterator<KWFrame> f = fs->frameIterator(); f.current() ; ++f ) {
> > +                    height=QMAX(height, f.current()->bottom());
> > +                }
> > +            }
> > +        }
> > +        while(height > ptPaperHeight() * getPages()) {
> > +            m_pages++;
> > +        }
> >      }
> > 
> >      if ( isHeaderVisible() ) {
> 
> Sad... I don't understand when this broke.
> I guess it affects _all_ DTP documents ?
I think so, yes.

> No other choice than repackaging 1.1.1 then ? :}

Hmm, well; nobody complained (AFAIK) with the 1.1 release.. I found out myself. 
but I would like it if you repackaged :)

> Hmm, BTW
> > +        while(height > ptPaperHeight() * getPages()) {
> > +            m_pages++;
> could be
>  m_pages = height / ptPaperHeight(), no ?

Right, I figured that out after I shut down my computer last night :)
You are welcome to do so; please check if you don't need rounding;
the following seems more correct...

     m_pages = static_cast<int>((height / ptPaperHeight()) + 0.5)


-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]