[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] add page on loading
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-12-12 9:48:03
[Download RAW message or body]

On Wednesday 12 December 2001 01:02, Thomas Zander wrote:
> Bug:
> Opening a multipage-DTP document (from the page-layout tab) did not create the
> right amount of pages. It always opens at 1 page.

Huh :(

> This close to the release of KOffice 1.1.1, could someone please post-commit check 
> this patch as I have to go to sleep now...

This close ? You mean _after_ ? :((
The tarballs are already done, and the binary packages have started to arrive.

> Index: kwdoc.cc
> ===================================================================
> RCS file: /home/kde/koffice/kword/kwdoc.cc,v
> retrieving revision 1.263.2.4
> diff -u -3 -p -d -r1.263.2.4 kwdoc.cc
> --- kwdoc.cc    2001/12/05 23:41:53     1.263.2.4
> +++ kwdoc.cc    2001/12/12 00:01:16
> @@ -634,7 +634,19 @@ void KWDocument::recalcFrames()
>                  }
>              }
>          }
> -
> +    } else {
> +        double height=0;
> +        for (QListIterator<KWFrameSet> fit = framesetsIterator(); fit.current() ; ++fit ) {
> +            if(fit.current()->frameSetInfo()==KWFrameSet::FI_BODY) {
> +                KWFrameSet * fs = fit.current();
> +                for (QListIterator<KWFrame> f = fs->frameIterator(); f.current() ; ++f ) {
> +                    height=QMAX(height, f.current()->bottom());
> +                }
> +            }
> +        }
> +        while(height > ptPaperHeight() * getPages()) {
> +            m_pages++;
> +        }
>      }
> 
>      if ( isHeaderVisible() ) {

Sad... I don't understand when this broke.
I guess it affects _all_ DTP documents ?
No other choice than repackaging 1.1.1 then ? :}

Hmm, BTW
> +        while(height > ptPaperHeight() * getPages()) {
> +            m_pages++;
could be
 m_pages = height / ptPaperHeight(), no ?

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE 3.0: Konquering the Desktops
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]