--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 12, 2001 at 10:48:03AM +0100, David Faure wrote:
> On Wednesday 12 December 2001 01:02, Thomas Zander wrote:
> > Bug:
> > Opening a multipage-DTP document (from the page-layout tab) did not cre=
ate the
> > right amount of pages. It always opens at 1 page.
>=20
> Huh :(
>=20
> > This close to the release of KOffice 1.1.1, could someone please post-c=
ommit check=20
> > this patch as I have to go to sleep now...
>=20
> This close ? You mean _after_ ? :((
> The tarballs are already done, and the binary packages have started to ar=
rive.

Hmm? When did you do that? Last email I saw on this subject is the Laurent=
=20
asked you to wait till end of this week so he could stabilize kchart...
And I saw lots of commits in the branch..
Sorry for the late commit, I simply did not have time to fix it earlier, I =
spotted
the problem some time ago; should have made a bugreport methinks. :(

> > Index: kwdoc.cc
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /home/kde/koffice/kword/kwdoc.cc,v
> > retrieving revision 1.263.2.4
> > diff -u -3 -p -d -r1.263.2.4 kwdoc.cc
> > --- kwdoc.cc    2001/12/05 23:41:53     1.263.2.4
> > +++ kwdoc.cc    2001/12/12 00:01:16
> > @@ -634,7 +634,19 @@ void KWDocument::recalcFrames()
> >                  }
> >              }
> >          }
> > -
> > +    } else {
> > +        double height=3D0;
> > +        for (QListIterator<KWFrameSet> fit =3D framesetsIterator(); fi=
t.current() ; ++fit ) {
> > +            if(fit.current()->frameSetInfo()=3D=3DKWFrameSet::FI_BODY)=
 {
> > +                KWFrameSet * fs =3D fit.current();
> > +                for (QListIterator<KWFrame> f =3D fs->frameIterator();=
 f.current() ; ++f ) {
> > +                    height=3DQMAX(height, f.current()->bottom());
> > +                }
> > +            }
> > +        }
> > +        while(height > ptPaperHeight() * getPages()) {
> > +            m_pages++;
> > +        }
> >      }
> >=20
> >      if ( isHeaderVisible() ) {
>=20
> Sad... I don't understand when this broke.
> I guess it affects _all_ DTP documents ?
I think so, yes.

> No other choice than repackaging 1.1.1 then ? :}

Hmm, well; nobody complained (AFAIK) with the 1.1 release.. I found out mys=
elf.=20
but I would like it if you repackaged :)

> Hmm, BTW
> > +        while(height > ptPaperHeight() * getPages()) {
> > +            m_pages++;
> could be
>  m_pages =3D height / ptPaperHeight(), no ?

Right, I figured that out after I shut down my computer last night :)
You are welcome to do so; please check if you don't need rounding;
the following seems more correct...

     m_pages =3D static_cast<int>((height / ptPaperHeight()) + 0.5)


--=20
Thomas Zander                                            zander@earthling.n=
et
The only thing worse than failure is the fear of trying something new

--yrj/dFKFPuw6o+aM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8FyuNCojCW6H2z/QRAknyAKCQzFyXqhIHjVXYNaYae5mQ0K3piwCfZZyA
QEtNoFlp7EQRsdbHo95cxtQ=
=dfSr
-----END PGP SIGNATURE-----

--yrj/dFKFPuw6o+aM--
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel