[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    [Bug 106011] New: KoUnitDoubleSpinBox has a design flaw
From:       Thomas Zander <zander () kde ! org>
Date:       2005-05-20 9:34:48
Message-ID: 20050520113447.106011.zander () kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=106011         
           Summary: KoUnitDoubleSpinBox has a design flaw
           Product: koffice
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: koffice kde org
        ReportedBy: zander kde org


Version:           1.4 (using KDE Devel)
Installed from:    Compiled sources

KoUnitDoubleSpinBox has a setValue(double) and a value() method; as they are used in \
kword/framedia.cc (KWFourSideConfigWidget)

It appears that the setter expects a value already converted using KoUnit, while the \
getter returns a pre-converted value. This breaks a very simple concept that 
setValue(1.0);
value() == 1.0
sould be true.

I recommend looking into this and probably refactor some code to make sure this is \
consistent after 1.4 is released. Note that I found some 100 usages of the class on a \
quick grep. ____________________________________
koffice mailing list
koffice@kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic