From koffice  Fri May 20 09:34:48 2005
From: Thomas Zander <zander () kde ! org>
Date: Fri, 20 May 2005 09:34:48 +0000
To: koffice
Subject: [Bug 106011] New: KoUnitDoubleSpinBox has a design flaw
Message-Id: <20050520113447.106011.zander () kde ! org>
X-MARC-Message: https://marc.info/?l=koffice&m=111658180006908

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=106011         
           Summary: KoUnitDoubleSpinBox has a design flaw
           Product: koffice
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: koffice kde org
        ReportedBy: zander kde org


Version:           1.4 (using KDE Devel)
Installed from:    Compiled sources

KoUnitDoubleSpinBox has a setValue(double) and a value() method; as they are used in kword/framedia.cc (KWFourSideConfigWidget)

It appears that the setter expects a value already converted using KoUnit, while the getter returns a pre-converted value.
This breaks a very simple concept that 
setValue(1.0);
value() == 1.0
sould be true.

I recommend looking into this and probably refactor some code to make sure this is consistent after 1.4 is released.
Note that I found some 100 usages of the class on a quick grep.
____________________________________
koffice mailing list
koffice@kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice