[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH][RFC] outgoing filters and other stuff
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-05-24 9:51:40
[Download RAW message or body]

On Thursday, 24. May 2001 03:32, Marc Mutz wrote:
> Hi!
>
> This is the latest version of the patch that enables outgoing filters
> and other - already discussed - enhancements.

I think, actually we talked about checkboxes, but this combo box for incoming 
and outgoing mail is also nice. It even requires less space.

> I've done some initial testing of the outgoing filtering, too, and I
> can move a message to another folder after delivery.
>
> What remains to be done is changing the config format to be compatibe
> with fuyure planned changes. So, while the functionality is there, I
> don't want this to go into CVS because I don't want to write an
> importer for a config format whose lifetime is under a week.
>
> Please comment and if you like, try to break it. What I'm not quite
> sure of is the error handling in KMSeander::doSendMsg(), please have an
> eye on that.

As far as I can see, it looks good, however I didn't do heavy testing.

> PS: Another change has crept into the attached patch, which adds a
> button to KMFilterActionWithAddress parameter widgets that calls the
> addressbook. I have a problem with the button's size. Seems it wants to
> have much space around it. If someone has an idea, please tell me.

I currently can't see the problem. For me the width and height of the button 
are exactely the same as the height of the edit field and there is no space 
between the edit field and the button.

Regards,
Michael Häckel

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]