[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: kmail: bugreport+bugfix (nested multipart messages)
From:       Don Sanders <sanders () kde ! org>
Date:       2000-09-29 3:05:24
[Download RAW message or body]

I converted Daniel F Moisset's patch to C++. I can't reproduce the problem 
with html mail being shown when "Prefer HTML" is disabled.

I also tried to improve handling of message digests. If possible message 
attachments without names will show the subject of the message besides the 
attachment icon, and as a last result the string "Attachment: " + 
attachment_number is shown. ("Attachment: " had already been i18n'd elsewhere 
in KMail).

Maybe someone can check the patch.

BFN,
Don.

On Wed, 27 Sep 2000, Michael Haeckel wrote:

> > On Wednesday, 27. September 2000, Daniel F Moisset wrote:
> > The result with the patch is the following:
> >   The first message is displayed when "Prefer HTML to text" is
> > enabled; both parts are displayed (text/plain and text/html). When
> > "Prefer HTML" is disabled, both parts are shown, but the text/html is not
> > rendered; the HTML source is displayed instead. (That is with View|Inline
> > attachments selected).
>
> It is intended to not render any HTML code in a mail when "Prefer HTML" is
> disabled for security reasons.
> But with your patch I saw this happen with an example mail sent some days
> ago the KMail list, I attached it again.
>
> > I don't know if that's the desired behavior, but at least parts are
> > separated, and decoded according to Content-Transfer-Encoding.
> >   The second message is still rendered incorrectly; apparently mimelib
> > fails to recognize it as a multipart message. Perhaps the format is
> > incorrect (it was artificially composed), but PINE shows the parts as I
> > think they should be.
> >
> > Anyway, it will be ugly. KMMessage::getBodyPart() makes the message look
> > like a list of parts, when it's actually a tree. I changed it so it now
> > reads all the leaf nodes (attachments) instead of only the top level, but
> > a clean fix should involve changing the interfaec of kmmesage (ie,
> > kmmessage, and all its client classes).
>
> Your patch now display as far as I can see all body parts. That is an
> improvement, but it still does not show them as it should. For example if
> there is a text and a html part then only one of both should be displayed.
> I think pine does that in a similar way as your patch does.
>
> I think your patch is a good temporary solution and we should include it
> until we have something better which will display the mails correctely.
> But no HTML code from the mail must be rendered when "Prefer HTML" is
> disabled. This has to be fixed before we include your patch.
>
> Regards,
> Michael Häckel

["htmlattach.mail" (message/rfc822)]


_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]