'Re: kmail: bugreport+bugfix (nested multipart messages)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: kmail: bugreport+bugfix (nested multipart messages)
From:       Michael Haeckel <Michael () Haeckel ! Net>
Date:       2000-09-27 20:58:38
[Download RAW message or body]

On Wednesday, 27. September 2000, Daniel F Moisset wrote:
>
> The result with the patch is the following:
>   The first message is displayed when "Prefer HTML to text" is
> enabled; both parts are displayed (text/plain and text/html). When "Prefer
> HTML" is disabled, both parts are shown, but the text/html is not
> rendered; the HTML source is displayed instead. (That is with View|Inline
> attachments selected).

It is intended to not render any HTML code in a mail when "Prefer HTML" is 
disabled for security reasons.
But with your patch I saw this happen with an example mail sent some days ago 
the KMail list, I attached it again.

> I don't know if that's the desired behavior, but at least parts are
> separated, and decoded according to Content-Transfer-Encoding.
>   The second message is still rendered incorrectly; apparently mimelib
> fails to recognize it as a multipart message. Perhaps the format is
> incorrect (it was artificially composed), but PINE shows the parts as I
> think they should be.
>
> Anyway, it will be ugly. KMMessage::getBodyPart() makes the message look
> like a list of parts, when it's actually a tree. I changed it so it now
> reads all the leaf nodes (attachments) instead of only the top level, but
> a clean fix should involve changing the interfaec of kmmesage (ie,
> kmmessage, and all its client classes).

Your patch now display as far as I can see all body parts. That is an 
improvement, but it still does not show them as it should. For example if 
there is a text and a html part then only one of both should be displayed. I 
think pine does that in a similar way as your patch does.

I think your patch is a good temporary solution and we should include it until 
we have something better which will display the mails correctely.
But no HTML code from the mail must be rendered when "Prefer HTML" is 
disabled. This has to be fixed before we include your patch.

Regards,
Michael Häckel
["htmlattach.mail" (message/rfc822)]

C'est un message de format MIME en plusieurs parties.

[Attachment #5 (multipart/alternative)]

Bonjour,

Ceci est un test

-------------------------------------------------------------------------=
-------

[Attachment #8 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META content="MSHTML 5.00.2919.6307" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2>Bonjour,</FONT></DIV>
<DIV>&nbsp;</DIV>
<DIV><FONT size=2>Ceci est un test</FONT></DIV>
<DIV>
<HR>
</DIV>
<DIV><IMG align=baseline alt="" border=0 hspace=0 
src="cid:009d01c02498$6bf940e0$995ba8c0@tiscalinet.be"></DIV></BODY></HTML>

["perdu - communiste.gif 3.gif" (image/gif)]
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread] 