[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Fix and question for 146967
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2007-06-25 21:37:55
Message-ID: 200706252338.02834 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 25 June 2007 19:35, Jonathan Marten wrote:
> I've noticed this bug too - in KDE 3.5.7, PIM 3.5.5+, and IIRC in
> 3.5.6 as well.  The root cause seems to be that the compaction job
> leaves the folder closed when it is finished - by doing
>
>   mbox->close("mboxcompact", true);
>
> in MboxCompactionJob::done(), and KMHeaders fails to reopen the
> folder before using it in either KMHeaders::readSortOrder() or
> KMHeaders::setCurrentItemByIndex().
>
> So my question for the experts is: would it be a reasonable fix to
> just change the above line to not force the close, i.e. remove the
> 'true' parameter?  The corresponding code for compacting a maildir
> folder (in MaildirCompactionJob::done()) does not force close the
> folder - and maildir compaction works with no problems.

The difference between maildir and mbox is that in the case of mbox the 
compacted mbox is stored in a new mbox file. This new mbox file 
replaces the old mbox file and in order for this replacing to work the 
old mbox storage must be closed and the new one must be opened. Without 
having a closer look at the code I currently don't know how to open the 
folder again.

A much safer solution for this bug is the conversion of all mbox folder 
to maildir format.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]