[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Fix and question for 146967
From:       Jonathan Marten <jjm2 () keelhaul ! demon ! co ! uk>
Date:       2007-06-25 17:35:45
Message-ID: ovvedcszri.fsf () keelhaul ! local
[Download RAW message or body]

I've noticed this bug too - in KDE 3.5.7, PIM 3.5.5+, and IIRC in
3.5.6 as well.  The root cause seems to be that the compaction job
leaves the folder closed when it is finished - by doing

  mbox->close("mboxcompact", true);

in MboxCompactionJob::done(), and KMHeaders fails to reopen the folder
before using it in either KMHeaders::readSortOrder() or
KMHeaders::setCurrentItemByIndex().

So my question for the experts is: would it be a reasonable fix to
just change the above line to not force the close, i.e. remove the
'true' parameter?  The corresponding code for compacting a maildir
folder (in MaildirCompactionJob::done()) does not force close the
folder - and maildir compaction works with no problems.

By the way, some of the 'owner' parameters used in compactionjob.cpp
seem inconsistent (open with "mboxcompactjob", close using
"mboxcompact").  I'd guess these reall ought to match, although this
is not a problem because the names are never actually used...

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@keelhaul.demon.co.uk
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]