--===============1999540689== Content-type: multipart/signed; boundary=nextPart1310641.pVeWcox8ED; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-transfer-encoding: 7bit --nextPart1310641.pVeWcox8ED Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 25 June 2007 19:35, Jonathan Marten wrote: > I've noticed this bug too - in KDE 3.5.7, PIM 3.5.5+, and IIRC in > 3.5.6 as well. The root cause seems to be that the compaction job > leaves the folder closed when it is finished - by doing > > mbox->close("mboxcompact", true); > > in MboxCompactionJob::done(), and KMHeaders fails to reopen the > folder before using it in either KMHeaders::readSortOrder() or > KMHeaders::setCurrentItemByIndex(). > > So my question for the experts is: would it be a reasonable fix to > just change the above line to not force the close, i.e. remove the > 'true' parameter? The corresponding code for compacting a maildir > folder (in MaildirCompactionJob::done()) does not force close the > folder - and maildir compaction works with no problems. The difference between maildir and mbox is that in the case of mbox the=20 compacted mbox is stored in a new mbox file. This new mbox file=20 replaces the old mbox file and in order for this replacing to work the=20 old mbox storage must be closed and the new one must be opened. Without=20 having a closer look at the code I currently don't know how to open the=20 folder again. A much safer solution for this bug is the conversion of all mbox folder=20 to maildir format. Regards, Ingo --nextPart1310641.pVeWcox8ED Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBGgDW6GnR+RTDgudgRAjxZAKC5r3H2ghBNXHC1zfjZYIwf2IkrDACfdqYD kxi2BcHHYHiMtnk+zji9jPI= =/b3l -----END PGP SIGNATURE----- --nextPart1310641.pVeWcox8ED-- --===============1999540689== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KMail developers mailing list KMail-devel@kde.org https://mail.kde.org/mailman/listinfo/kmail-devel --===============1999540689==--