[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Find/Copy/Select all (was: delete message button for
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2006-09-29 18:28:56
Message-ID: 200609292029.04403 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 29 September 2006 10:31, Christian Zangl wrote:
> On Wednesday 27 September 2006 22:09, Ingo Klöcker <kloecker@kde.org> 
wrote:
> > Adding KMReaderWin::findText() is not necessary since we do already
> > have KMReaderWin::slotFind().
>
> I fixed that (including the coding style) and committed my first
> patch (yeah :-) ).

Great.

> > While you are at it you might also add Find
> > Next to the main window (KMMainWidget).
>
> To do that I'd have to add a new string "Find Next in Message" but
> the release plan says that messages are currently frozen, right?

True. We'll have to wait for the next unfreeze.

> > Your usage of spaces doesn't follow our coding style (see
> > http://pim.kde.org/development/coding-korganizer.php), but apart
> > from that your patch looks very good.
>
> I changed my code -- however the coding style in the source is very
> inconsistent. Wouldn't it be a good idea to beautify the code at some
> stage?

Nope. We shouldn't waste time doing so. We'd better concentrate on doing 
important stuff like fixing bugs.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]