From kmail-devel  Fri Sep 29 18:28:56 2006
From: Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Fri, 29 Sep 2006 18:28:56 +0000
To: kmail-devel
Subject: Re: [PATCH] Find/Copy/Select all (was: delete message button for
Message-Id: <200609292029.04403 () erwin ! ingo-kloecker ! de>
X-MARC-Message: https://marc.info/?l=kmail-devel&m=115955450030218
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1065383470=="

--===============1065383470==
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary=nextPart2449974.zJtLrEVvZ2
Content-transfer-encoding: 7bit

--nextPart2449974.zJtLrEVvZ2
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 29 September 2006 10:31, Christian Zangl wrote:
> On Wednesday 27 September 2006 22:09, Ingo Kl=F6cker <kloecker@kde.org>=20
wrote:
> > Adding KMReaderWin::findText() is not necessary since we do already
> > have KMReaderWin::slotFind().
>
> I fixed that (including the coding style) and committed my first
> patch (yeah :-) ).

Great.

> > While you are at it you might also add Find
> > Next to the main window (KMMainWidget).
>
> To do that I'd have to add a new string "Find Next in Message" but
> the release plan says that messages are currently frozen, right?

True. We'll have to wait for the next unfreeze.

> > Your usage of spaces doesn't follow our coding style (see
> > http://pim.kde.org/development/coding-korganizer.php), but apart
> > from that your patch looks very good.
>
> I changed my code -- however the coding style in the source is very
> inconsistent. Wouldn't it be a good idea to beautify the code at some
> stage?

Nope. We shouldn't waste time doing so. We'd better concentrate on doing=20
important stuff like fixing bugs.

Regards,
Ingo

--nextPart2449974.zJtLrEVvZ2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBFHWXwGnR+RTDgudgRAuBLAJ9dGrb14TQ7O2zC0H6+6lUL+mZ4iACfe3jZ
tjz0N1Q0kvT1DZTrW6oSsyQ=
=g0Bz
-----END PGP SIGNATURE-----

--nextPart2449974.zJtLrEVvZ2--


--===============1065383470==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

--===============1065383470==--