[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Find/Copy/Select all (was: delete message button for
From:       Christian Zangl <cza () sixxac ! com>
Date:       2006-09-29 8:31:53
Message-ID: 200609291031.54117.cza () sixxac ! com
[Download RAW message or body]

On Wednesday 27 September 2006 22:09, Ingo Klöcker <kloecker@kde.org> wrote:
> Adding KMReaderWin::findText() is not necessary since we do already have
> KMReaderWin::slotFind(). 

I fixed that (including the coding style) and committed my first patch 
(yeah :-) ).

> While you are at it you might also add Find 
> Next to the main window (KMMainWidget).

To do that I'd have to add a new string "Find Next in Message" but the release 
plan says that messages are currently frozen, right?

> Your usage of spaces doesn't follow our coding style (see
> http://pim.kde.org/development/coding-korganizer.php), but apart from
> that your patch looks very good.

I changed my code -- however the coding style in the source is very 
inconsistent. Wouldn't it be a good idea to beautify the code at some stage?

bye, chris
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]