[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Find/Copy/Select all (was: delete message button for
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2006-09-27 20:09:50
Message-ID: 200609272209.57420 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 27 September 2006 19:41, Christian Zangl wrote:
> OK, I've added the Find, Copy and Select all commands and have also
> thrown in a Find Next for good measure ;-)

Great.

> "Move to Trash" is now also on the Edit menu. The new menu entries
> require no new strings.
>
> Please take a look at it and let me know if I can commit it (now that
> I have commit access).

Adding KMReaderWin::findText() is not necessary since we do already have 
KMReaderWin::slotFind(). While you are at it you might also add Find 
Next to the main window (KMMainWidget).

Your usage of spaces doesn't follow our coding style (see 
http://pim.kde.org/development/coding-korganizer.php), but apart from 
that your patch looks very good.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]