[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2005-04-16 11:22:48
Message-ID: 200504161322.59661 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 16 April 2005 12:58, Paul Sprakes wrote:
> On Friday 15 Apr 2005 21:52, Ingo Klöcker wrote:
> > On Friday 15 April 2005 11:08, Paul Sprakes wrote:
> > > > Is this one OK to commit?
> > >
> > > Anyone?
> >
> > Looks good except for two things:
> > - Your patch adds yet another batch of duplicated code. It would be
> > really nice if at least some of the openComposer() methods could be
> > merged or at least some helper functions could be used to reduce
> > the code duplication. But this problem can be tackled after you've
> > committed your patch.
> > - I think we should rename newMessage() to newMessageInternal().
> > This way we can later add a public newMessage() DCOP call without
> > having to worry about the private one. Moreover, the "internal"
> > should make clear to everyone that this DCOP call is not supposed
> > to be called by external applications.
>
> Committed, thanks.
>
> I initially wanted to try to merge it in some way but didn't want to
> break anything :-) Besides, if the MailComposerIFace was extended a
> bit, I think it could be reduced to just one method (maybe two - one
> to create a composer and another for a quick fire send). That way the
> returned DCOPRef could be used to set additional properties instead
> of passing loads of variations into the initial call.

Yes, I think that's the way to go.

> Would that be suitable? and if so when could it be done (by me)?

We've decided not to break the public DCOP API before KDE 4.0. Thus 
we'll have to keep all those openComposer() calls for KDE 3.5. But, of 
course, this doesn't mean that you can't start extending 
MailComposerIFace today.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]