[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Don Sanders <sanders () kde ! org>
Date:       2005-04-19 7:54:43
Message-ID: 200504190754.43566.sanders () kde ! org
[Download RAW message or body]

On Friday 08 April 2005 14:25, Paul Sprakes wrote:
> On Friday 08 Apr 2005 14:39, Paul Sprakes wrote:
> > On Friday 08 Apr 2005 14:05, David Faure wrote:
> > > On Friday 08 April 2005 13:14, Paul Sprakes wrote:
> > > > Currently, the folder identity is not used when composing a
> > > > new mail from Kontact. The attached patch fixes that.
> > >
> > > This screams for a helper function or method to avoid the code
> > > duplication, IMHO.
> >
> > Will do. Not sure why I didn't in the first place :-(
>
> And here it is. Is this one OK?

Sorry I didn't have time to test, but the basic approach looks ok to 
me.

Well, one thing I am concerned about is the use of 
KMMainWidget *KMKernel::getKMMainWidget(). I don't like this function 
because it ignores the case of multiple main windows being open (try 
File->New Window).

IIRC basically any code (including yours) that uses that function is 
buggy because it won't handle the case of multiple main windows.

However this is just a comment (documentation) and not an objection to 
you committing. If you've really tested it and fixed .. aah the 
Kontact specific bug I forget the bug number... them I'm pro the 
patch being committed. (But please be aware of the problem with 
getKMMainWidget).

Maybe you could even mention in your commit that it should be 
considered for backporting to the KDE_3_4_BRANCH.

Don.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]