[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Paul Sprakes <paul () sprakes ! co ! uk>
Date:       2005-04-16 10:58:41
Message-ID: 200504161158.42102.paul () sprakes ! co ! uk
[Download RAW message or body]

On Friday 15 Apr 2005 21:52, Ingo Klöcker wrote:
> On Friday 15 April 2005 11:08, Paul Sprakes wrote:
> > > Is this one OK to commit?
> >
> > Anyone?
>
> Looks good except for two things:
> - Your patch adds yet another batch of duplicated code. It would be
> really nice if at least some of the openComposer() methods could be
> merged or at least some helper functions could be used to reduce the
> code duplication. But this problem can be tackled after you've
> committed your patch.
> - I think we should rename newMessage() to newMessageInternal(). This
> way we can later add a public newMessage() DCOP call without having to
> worry about the private one. Moreover, the "internal" should make clear
> to everyone that this DCOP call is not supposed to be called by
> external applications.

Committed, thanks.

I initially wanted to try to merge it in some way but didn't want to break 
anything :-) Besides, if the MailComposerIFace was extended a bit, I think it 
could be reduced to just one method (maybe two - one to create a composer and 
another for a quick fire send). That way the returned DCOPRef could be used 
to set additional properties instead of passing loads of variations into the 
initial call. 

Would that be suitable? and if so when could it be done (by me)?

Thanks, Paul.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]