[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2005-04-15 20:52:19
Message-ID: 200504152252.36358 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 15 April 2005 11:08, Paul Sprakes wrote:
> > Is this one OK to commit?
>
> Anyone?

Looks good except for two things:
- Your patch adds yet another batch of duplicated code. It would be 
really nice if at least some of the openComposer() methods could be 
merged or at least some helper functions could be used to reduce the 
code duplication. But this problem can be tackled after you've 
committed your patch.
- I think we should rename newMessage() to newMessageInternal(). This 
way we can later add a public newMessage() DCOP call without having to 
worry about the private one. Moreover, the "internal" should make clear 
to everyone that this DCOP call is not supposed to be called by 
external applications.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]