[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Paul Sprakes <paul () sprakes ! co ! uk>
Date:       2005-04-08 22:48:53
Message-ID: 200504082348.54568.paul () sprakes ! co ! uk
[Download RAW message or body]

On Friday 08 Apr 2005 23:23, Ingo Klöcker wrote:
> On Friday 08 April 2005 13:14, Paul Sprakes wrote:
> > Currently, the folder identity is not used when composing a new mail
> > from Kontact. The attached patch fixes that.
> >
> > There are a few bug reports about this but they all seem to be fixed?
> >
> > Is it OK to commit?
>
> No. Your patch doesn't only address the problem with Kontact but it
> makes KMail always use the folder identity if a new message window is
> opened via DCOP. I don't think this is always desired. In particular,
> if I click on an email address on a web page or if I select "Send
> Message To" from KAddressBook/Contacts then the default identity should
> be used. Using the folder identity really only makes sense when the
> user clicks on the New Message icon in Kontact. Otherwise it doesn't
> make sense.
>
> What this boils down to is that we either need special DCOP calls for
> Kontact or that we need to add another option to the DCOP calls. Since
> both requires the introduction of new DCOP calls (because the DCOP API
> has to stay backwards compatible) we should simply add special hidden
> DCOP calls for Kontact.
>
> Regards,
> Ingo

Right, I see. I haven't really looked at DCOP before so not sure how to go 
about creating hidden ones. Could you point out some example I could look at?

Looking at newInstance() in KMailPlugin the first thing it does is:

DCOPReply reply = kmail.call( "handleCommandLine", false );

Would adding something like:

DCOPReply reply = kmail.call( "useFolderIdentities", true );

Not be sufficient? The other option seems to me to duplicate loads of calls 
with an extra option.


Thanks, Paul.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]