[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2005-04-08 23:00:54
Message-ID: 200504090100.55642 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 09 April 2005 00:48, Paul Sprakes wrote:
> On Friday 08 Apr 2005 23:23, Ingo Klöcker wrote:
> > On Friday 08 April 2005 13:14, Paul Sprakes wrote:
> > > Currently, the folder identity is not used when composing a new
> > > mail from Kontact. The attached patch fixes that.
> > >
> > > There are a few bug reports about this but they all seem to be
> > > fixed?
> > >
> > > Is it OK to commit?
> >
> > No. Your patch doesn't only address the problem with Kontact but it
> > makes KMail always use the folder identity if a new message window
> > is opened via DCOP. I don't think this is always desired. In
> > particular, if I click on an email address on a web page or if I
> > select "Send Message To" from KAddressBook/Contacts then the
> > default identity should be used. Using the folder identity really
> > only makes sense when the user clicks on the New Message icon in
> > Kontact. Otherwise it doesn't make sense.
> >
> > What this boils down to is that we either need special DCOP calls
> > for Kontact or that we need to add another option to the DCOP
> > calls. Since both requires the introduction of new DCOP calls
> > (because the DCOP API has to stay backwards compatible) we should
> > simply add special hidden DCOP calls for Kontact.
>
> Right, I see. I haven't really looked at DCOP before so not sure how
> to go about creating hidden ones. Could you point out some example I
> could look at?

See kmailIface.h and look for k_dcop_hidden.

> Looking at newInstance() in KMailPlugin the first thing it does is:
>
> DCOPReply reply = kmail.call( "handleCommandLine", false );
>
> Would adding something like:
>
> DCOPReply reply = kmail.call( "useFolderIdentities", true );
>
> Not be sufficient?

I don't think so because it could interfere with other DCOP calls coming 
from other applications.

> The other option seems to me to duplicate loads of 
> calls with an extra option.

We probably don't need to duplicate all of those calls for Kontact.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]