[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Use folder identity when composing from kontact/dcop
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2005-04-08 22:23:07
Message-ID: 200504090023.12107 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 08 April 2005 13:14, Paul Sprakes wrote:
> Currently, the folder identity is not used when composing a new mail
> from Kontact. The attached patch fixes that.
>
> There are a few bug reports about this but they all seem to be fixed?
>
> Is it OK to commit?

No. Your patch doesn't only address the problem with Kontact but it 
makes KMail always use the folder identity if a new message window is 
opened via DCOP. I don't think this is always desired. In particular, 
if I click on an email address on a web page or if I select "Send 
Message To" from KAddressBook/Contacts then the default identity should 
be used. Using the folder identity really only makes sense when the 
user clicks on the New Message icon in Kontact. Otherwise it doesn't 
make sense.

What this boils down to is that we either need special DCOP calls for 
Kontact or that we need to add another option to the DCOP calls. Since 
both requires the introduction of new DCOP calls (because the DCOP API 
has to stay backwards compatible) we should simply add special hidden 
DCOP calls for Kontact.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]