[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Copy Filter Action - review please
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2004-11-29 19:48:52
Message-ID: 200411292048.59942 () gungl-dd ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 28 November 2004 23:23, Ingo Klöcker wrote:
> On Sunday 28 November 2004 21:17, Andreas Gungl wrote:
> > Hi,
> >
> > The attached patch introduces a Copy filter action. I've tested with
> > incoming messages as well as when applying manually. Can you please
> > have a look at it and tell me if you find some critical code?
>
> Do we really need a separate "Copy into Folder" filter action? IMO, no.
> Shouldn't multiple "File into Folder" filter actions just do the same?
> IMO, yes. The only problem with "File into Folder" is that it's always
> done as last action. This makes it impossible to do for example the
> following: File a copy into a backup folder, modify the message (with a
> script or the header modification actions), file the modified copy into
> another folder.

Do you really think that "File into Folder" should put a copy of a message 
into a folder? What would be the semantic of subsequent "File into Folder" 
actions within one filter rule? What would happen with a message having one 
"File into Folder" actions in each of some rules which are all applied to 
the message?
Don't you think that it's much easier for a user to handle a "Move into 
Folder" plus a "Copy into Folder" action? What about the usability 
argument?

> Opening and closing the folder in KMFilterActionCopy::process() can be
> very slow. It would be better if the folders were kept open until
> filtering is finished. IIRC "File into Folder" already works like this.

The behavior could be changed. However I wonder how keeping folders open can 
work when the filters are processed asynchronously and thus perhaps in 
parallel. It might be a hard job to synchronize this.

> Will mFolder->addMsg work for IMAP folders? I guess this will require
> the usage of the ActionScheduler Don is working on.
>
> I don't think it makes much sense to further look into this before Don's
> changes are in place.

My change is nearly trivial against the changes Don is working on. I really 
don't see how my change could be a high risk for Don's progress. But of 
course it's the best to wait for his comment.

Regards,
Andreas

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]