[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Copy Filter Action - review please
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2004-11-28 22:23:38
Message-ID: 200411282323.39487 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 28 November 2004 21:17, Andreas Gungl wrote:
> Hi,
>
> The attached patch introduces a Copy filter action. I've tested with
> incoming messages as well as when applying manually. Can you please
> have a look at it and tell me if you find some critical code?

Do we really need a separate "Copy into Folder" filter action? IMO, no. 
Shouldn't multiple "File into Folder" filter actions just do the same? 
IMO, yes. The only problem with "File into Folder" is that it's always 
done as last action. This makes it impossible to do for example the 
following: File a copy into a backup folder, modify the message (with a 
script or the header modification actions), file the modified copy into 
another folder.

Opening and closing the folder in KMFilterActionCopy::process() can be 
very slow. It would be better if the folders were kept open until 
filtering is finished. IIRC "File into Folder" already works like this.

Will mFolder->addMsg work for IMAP folders? I guess this will require 
the usage of the ActionScheduler Don is working on.

I don't think it makes much sense to further look into this before Don's 
changes are in place.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]