[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: New action: move to next unread message or folder
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-07-19 12:14:38
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 19 July 2003 10:32, David Smith wrote:
> On Friday 18 July 2003 23.16, Ingo Klöcker wrote:
> > Thanks for the patch. It looks good. In the last line of the
> > QWhatsThis is a typo (depeding -> depending).
>
> Ha, ha. If you spotted that I'm assured no programming bugs could
> slip through either :)
>
> > Furthermore please add "diff -u3 -p"
> > to your ~/.cvsrc. The -p will make your diffs slightly better
> > readable. Do you have a cvs account? Or should I commit the patch?
>
> I can commit (i think, it's been a while...)
>
> > A little thing is still missing. We'll have to write a kconf_update
> > script which upgrades the boolean value of LoopOnGotoUnread to an
> > integer.
>
> Didn't know about that. That's a script like
> kmail-3.1-loop-on-goto-unread.pl like this, right?

Well, it should be called kmail-3.2-loop-on-goto-unread.pl because it's 
for upgrading to KMail 3.2.

> #!/usr/bin/perl -w
> use strict;
> while ( <> ) {
>       if ( /^\[Behaviour\]/ ... /^\[/ ) {
>              # true => Loop in current folder
>              # false => Don't loop
>              s/^LoopOnGotoUnread=true/LoopOnGotoUnread=1/;
>              s/^LoopOnGotoUnread=false/LoopOnGotoUnread=0/;
>        }
>        print;
> }
>
> And it should be added to the Makefile.am and to kmail.upd?

Yes. But the if statement isn't really necessary. The following simpler 
script should do the trick:

#!/usr/bin/perl -w
use strict;
while ( <> ) {
  # true => Loop in current folder
  # false => Don't loop
  s/^LoopOnGotoUnread=true/LoopOnGotoUnread=1/;
  s/^LoopOnGotoUnread=false/LoopOnGotoUnread=0/;
  print;
}

Regards,
Ingo


[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]