[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [KROUPWARE MERGE] RFC compliant MDN support
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-12-30 17:49:28
[Download RAW message or body]

On Monday 30 December 2002 17:46, Marc Mutz wrote:
> On Friday 27 December 2002 01:23, Ingo Klöcker wrote:
> > On Thursday 26 December 2002 15:39, Marc Mutz wrote:
> > 002_use_mutable_dwmessage_to_make_some_methods_const_and_implement_
> >he aderAsSendableString: KMMessage::headerAsSendableString() looks
> > very expensive since a copy of the whole message is created
> > although only the headers are needed. It should be possible to do
> > this in a better way, e.g. copy only the headers, create a dummy
> > message with an empty body with these headers and then do the rest
> > (strip off the headers which shouldn't be sent and extract the
> > remaining headers).
>
> like so?
>
>  QCString KMMessage::headerAsSendableString() const
>  {
>    KMMessage msg;
> -  msg.fromString(asString());
> +  msg.fromString(headerAsString()+'\n');
>    msg.removePrivateHeaderFields();
>    msg.removeHeaderField("Bcc");
>    return msg.headerAsString().latin1();
>  }

Nice.

> > Why do you use QMessageBox instead of KMessageBox? As KMessageBoxes
> > provide the correct spacing (cf. KDE style guide) please use them
> > instead of the Q* variants.
>
> If you show me a KMessageBox that can show three buttons with free
> choosing of button texts....

Well, if KMessageBox doesn't provide what you need then please extend it 
accordingly and propose this extension for inclusion into kdelibs on 
kde-core-devel.

> > > 007_*: send MDNs from filters, either by a dedicated action of
> > > else when removing or forwarding.
> >
> > The
> >   //delete mdn;
> > in KMFilterAction::SendMDN(...) looks fishy. Must the mdn be
> > deleted or not? If yes, delete it. If no, remove the comment and
> > maybe add a comment why it doesn't have to be deleted.
>
> You can't decide that, if you look at kmsender::send(). It returns
> false after successful addition to outbox (don't delete) as well as
> before (delete).

So we have a memory leak under certain circumstances, or what?

> > Please create a draft for the necessary documentation changes and
> > send it to Daniel.
>
> Kalle is supposed to have written the Kolab client docs. I'm sure he
> will release them once they're finished.

ok

Regards,
Ingo


[Attachment #3 (application/pgp-signature)]
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]