[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [KROUPWARE MERGE] RFC compliant MDN support
From:       Marc Mutz <mutz () kde ! org>
Date:       2002-12-30 16:46:54
[Download RAW message or body]

On Friday 27 December 2002 01:23, Ingo Klöcker wrote:
> On Thursday 26 December 2002 15:39, Marc Mutz wrote:
> > OK, here is a version that actually applies (to 3_1_BRANCH):
> >
> > 000_*: candidates for 3.1.0
>
> Please apply to 3_1
<snip>

Done.

> 001_implement_findDwBodyPart:
> Contains a pending(khz). What about it?
>
> >  - setBodyFromUnicode should be ported to KMMessage, too
> > 002_*: use the mutable dwmessage memebr to make some methods const
> > that should be const and implement a asSendableString for headers.
>
> 002_use_mutable_dwmessage_to_make_some_methods_const_and_implement_he
>aderAsSendableString: KMMessage::headerAsSendableString() looks very
> expensive since a copy of the whole message is created although only
> the headers are needed. It should be possible to do this in a better
> way, e.g. copy only the headers, create a dummy message with an empty
> body with these headers and then do the rest (strip off the headers
> which shouldn't be sent and extract the remaining headers).

like so?

 QCString KMMessage::headerAsSendableString() const
 {
   KMMessage msg;
-  msg.fromString(asString());
+  msg.fromString(headerAsString()+'\n');
   msg.removePrivateHeaderFields();
   msg.removeHeaderField("Bcc");
   return msg.headerAsString().latin1();
 }


<snip>
> Why do you use QMessageBox instead of KMessageBox? As KMessageBoxes
> provide the correct spacing (cf. KDE style guide) please use them
> instead of the Q* variants.

If you show me a KMessageBox that can show three buttons with free 
choosing of button texts....

> > 004_*: Actually send MDNs wen messages are marked as read.
>
> 004_send_mdns_when_read:
> +         KMessageBox::error( this, i18n("Couldn't send MDN!") );
>
> Please don't abbreviate "MDN" here. Furthermore this error message
> doesn't help the user since he doesn't know what went wrong so that
> he can't do anything about it. This error message should probably
> point the user to the manual, i.e. the FAQ, where some possible
> errors and solutions are presented.

The exact problem is reported by kmsender.

> > 005_*: RFC requires MDNs to be sent at most once per message.
> > Implement that by storing the MDN sent state in the index
> > 006_*: Remove the confirm delivery option (there's no standard way
> > to request them) and rename the menu item for requesting MDNs.
>
> Both look good.
>
> > 007_*: send MDNs from filters, either by a dedicated action of else
> > when removing or forwarding.
>
> The
>   //delete mdn;
> in KMFilterAction::SendMDN(...) looks fishy. Must the mdn be deleted
> or not? If yes, delete it. If no, remove the comment and maybe add a
> comment why it doesn't have to be deleted.

You can't decide that, if you look at kmsender::send(). It returns false 
after successful addition to outbox (don't delete) as well as before 
(delete).

<snip>
> Please create a draft for the necessary documentation changes and
> send it to Daniel.
<snip>

Kalle is supposed to have written the Kolab client docs. I'm sure he 
will release them once they're finished.

Marc

-- 
It has become fashionable in the post Cold War world to label
opponents as terrorists [...]. By doing so, the authorities instill
within society a culture of fear, leading people to accept that their
rights (and the rights of others) be trampled on for the sake of the
common good. In other words, it justifies the loss of privacy and a
state of surveillance they would otherwise not accept. Both communism
and fascism were examples of this technique used to perfection.
                  -- John Horvath: The Internet: A Terrorist Network?
                     Telepolis 2001/08/22 (#9350)

[Attachment #3 (application/pgp-signature)]
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]