[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [KROUPWARE MERGE] RFC compliant MDN support
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-12-27 0:23:09
[Download RAW message or body]

On Thursday 26 December 2002 15:39, Marc Mutz wrote:
> OK, here is a version that actually applies (to 3_1_BRANCH):
>
> 000_*: candidates for 3.1.0

Please apply to 3_1

> 001_*: implement a few helper functions and make the dwmessage member
> mutable.

001_refactor_identity_extraction:
Typo: Replace
+     and if that fails queries the @ref #parent() folde for a default.
by
+     and if that fails queries the @ref #parent() folder for a default.

001_implement_findDwBodyPart:
Contains a pending(khz). What about it?

>  - setBodyFromUnicode should be ported to KMMessage, too
> 002_*: use the mutable dwmessage memebr to make some methods const
> that should be const and implement a asSendableString for headers.

002_use_mutable_dwmessage_to_make_some_methods_const_and_implement_headerAsSendableString:
KMMessage::headerAsSendableString() looks very expensive since a copy of 
the whole message is created although only the headers are needed. It 
should be possible to do this in a better way, e.g. copy only the 
headers, create a dummy message with an empty body with these headers 
and then do the rest (strip off the headers which shouldn't be sent and 
extract the remaining headers).

> 003_*: The heart of the patch: implement createMDN

003_implement_createMDN:
Typos: Replace
+      required felds with proper values. Th ereturned message is not
by
+      required fields with proper values. The returned message is not

Why do you use QMessageBox instead of KMessageBox? As KMessageBoxes 
provide the correct spacing (cf. KDE style guide) please use them 
instead of the Q* variants.

> 004_*: Actually send MDNs wen messages are marked as read.

004_send_mdns_when_read:
+         KMessageBox::error( this, i18n("Couldn't send MDN!") );

Please don't abbreviate "MDN" here. Furthermore this error message 
doesn't help the user since he doesn't know what went wrong so that he 
can't do anything about it. This error message should probably point 
the user to the manual, i.e. the FAQ, where some possible errors and 
solutions are presented.

> 005_*: RFC requires MDNs to be sent at most once per message.
> Implement that by storing the MDN sent state in the index
> 006_*: Remove the confirm delivery option (there's no standard way to
> request them) and rename the menu item for requesting MDNs.

Both look good.

> 007_*: send MDNs from filters, either by a dedicated action of else
> when removing or forwarding.

The
  //delete mdn;
in KMFilterAction::SendMDN(...) looks fishy. Must the mdn be deleted or 
not? If yes, delete it. If no, remove the comment and maybe add a 
comment why it doesn't have to be deleted.

> 008_*: add config options for MDNs

008_configgui:
Typo: Replace
+                          "confirmations undermines you privacy. See "
by
+                          "confirmations undermines your privacy. See "

+             "   (i.e. e.g. forwarded).</p>"
"i.e. e.g." should IMO be replaced by "e.g.".

Please create a draft for the necessary documentation changes and send 
it to Daniel.

Regards,
Ingo


[Attachment #3 (application/pgp-signature)]
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]