[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Fwd: Re: [MIC MERGE] remove duplicates feature
From:       Marc Mutz <mutz () kde ! org>
Date:       2002-12-27 0:19:24
[Download RAW message or body]

["forwarded message" (MESSAGE/RFC822)]

Return-path: rannirl@otherkin.net
Received: from localhost (localhost.localdomain [127.0.0.1])
 by dirichlet.mathematik.uni-bielefeld.de (Postfix)
 with ESMTP id 42FCB3FBB0 for <mmutz@localhost>; Fri,
 27 Dec 2002 01:12:23 +0100 (CET)
Received: from mail.uni-bielefeld.de [129.70.4.91] by localhost with POP3
 (fetchmail-6.1.0) for mmutz@localhost (single-drop); Fri,
 27 Dec 2002 01:12:23 +0100 (CET)
Received: from ktown.kde.org (kde.informatik.uni-kl.de [131.246.103.200])
 by mail.uni-bielefeld.de
 (Sun Internet Mail Server sims.4.0.2000.10.12.16.25.p8)
 with SMTP id <0H7Q00205OM4MS@mail.uni-bielefeld.de> for mmutz@sims-ms-daemon
 (ORCPT rfc822;Marc.Mutz@uni-bielefeld.de); Thu,
 26 Dec 2002 19:27:40 +0100 (MET)
Received: (qmail 3442 invoked by uid 1055); Thu, 26 Dec 2002 18:27:39 +0000
Received: (qmail 3439 invoked from network); Thu, 26 Dec 2002 18:27:39 +0000
Received: from nephilim.otherkin.net (207.245.72.101)
 by kde.informatik.uni-kl.de with SMTP; Thu, 26 Dec 2002 18:27:38 +0000
Received: (qmail 24716 invoked from network); Thu, 26 Dec 2002 18:36:52 +0000
Received: from bordermanager.meritind.com (HELO there) (12.41.2.2)
 by 0 with SMTP; Thu, 26 Dec 2002 18:36:52 +0000
Date: Thu, 26 Dec 2002 13:26:00 -0500
From: Malcolm-Rannirl <rannirl-kmail@otherkin.net>
Subject: Re: [MIC MERGE] remove duplicates feature
In-reply-to: <200212261712.11775@sendmail.mutz.com>
To: Marc Mutz <mutz@kde.org>
Message-id: <200212261320.08701@wibblesplat>
MIME-version: 1.0
X-Mailer: KMail [version 1.3.2]
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 7BIT
Delivered-to: mmutz@localhost.mathematik.uni-bielefeld.de
Delivered-to: kde.org-mutz@kde.org
X-Spam-Status: No,
 hits=-2.1 required=5.5	tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,SPAM_PHRASE_00_01	version=2.42
X-Spam-Level:
X-KMail-EncryptionState:
X-KMail-SignatureState:
References: <200212261712.11775@sendmail.mutz.com>
X-Status: N
Status: R

On Thursday 26 December 2002 11:12 am, Marc Mutz wrote:

> remove_dups.diff is the result of applying - in - order
> 004_remove_duplicates_feature
> 	Initial commit. Lacks menu item.

Looking at this code, what happens if the MD5s are the same, but the messages 
are different? It looks like it would delete things that aren't duplicates. I 
have seen this case when I tried to write a similar patch myself, so it can 
happen. (I ended up checking the date/time as well, as the combination seemed 
to be unique and the date field was cached and thus didn't need a full 
message read).

How does it cope with mails with no message ids? (I have archives like that, 
where the server adds the message id, so the saved outgoing mail does not 
have them). I'm not sure what kmail does for the md5 hash in that case.


_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]