[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: system tray notification patches updated for 3.1
From:       Ryan Breen <ryan () porivo ! com>
Date:       2002-06-09 23:42:32
[Download RAW message or body]


You're right about the multiple system trays when new KMMainWins are created 
-- I wrongly assumed that KMMainWin was a singleton :-)  I'll work on moving 
KMSystemTray to KMKernel.

As for the 'friend' association, KMSystemTray is a friend of KMFolderTree, not 
KMMainWin.  I needed this mod to connect to the mUpdateTimer for receiving 
delayedUpdate signals.  If there is a less obtrusive way of doing this, 
please let me know.

I switched to basing system tray notification off of 
KMFolderTree::delayedUpdate in response to a suggestion by Michael Häckel 
last November (http://lists.kde.org/?l=kmail&m=100506753530462&w=2).  The 
very earliest versions used KMFolderManager, but the suggestion was to use 
delayedUpdate to avoid additional folder traversal overhead.

Ryan

You wrote:
> reading through the patches (haven't tried them yet =/ ) i noticed that the 
> system tray icon is tied to the main window. in fact, KMSystemTray is made a 
> friend class of KMMainWindow... it looks like for each main window that the 
> user creates they get another system tray icon ....

> perhaps KMSystemTray would be better placed in KMKernel and if it used the 
> KMFolderManager to check which folders had unread messages? that way it 
> wouldn't need to be a friend of nor be tied to KMMainWindow, but rather to 
> the KMail process itself. it would also mean there is always at most one 
> system tray icon....

> thoughts?
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]