[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Abstracting date handling.
From:       Stephan Kulow <coolo () kde ! org>
Date:       2002-04-02 10:22:52
[Download RAW message or body]

On Saturday 30 March 2002 12:36, Zack Rusin wrote:
> Ave,
>
> I abstracted date handling. Let's get right to the point:
> a) why?
> - peer pressure. Everyone was doing it, I didn't want to be left out, so
> I tried it.
> - Marc suggested it,
> - message list and the reader weren't unified in that aspect,

That part at least was still on my TODO list on bugs.kde.org - so I'm glad
you picked it up :)

I looked briefly at your patch:
- leave out the "if (date)" before "delete date;", delete 0 is a perfect  
   instruction
- you're leaking _locale in case of the second constructor - I wonder
  what's for anyway, didn't find it's use in the patch.
- I wonder why in KMime, what has KMime to do with the way the
  date is displayed to the user?

Greetings, Stephan

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]