[prev in list] [next in list] [prev in thread] [next in thread] 

List:       klyx
Subject:    FIXED BUGS: KLyx
From:       Michael Brown <mcb30 () hermes ! cam ! ac ! uk>
Date:       2000-12-05 22:59:43
[Download RAW message or body]

The following bugs appear in klyx-2.0-1mdk (KDE date 20001017):

1) Icons in the drop-down math browsers (greek characters, binary
   relations, etc.) appear as the KDE "unknown" icon (the question mark
   picture)

2) While in Math Mode, it is not possible to enter expressions in Tex Mode
   (such as "\pi" or "\frac"), since Tex Mode is exited after entering
   only one character

I have fixed both of these.  A brief synopsis is as follows:

1) The icons in the drop-down browsers are stored in
   /usr/share/apps/klyx/pics as .xbm files.  KDE2  only searches for
   filenames with a .xpm or .png extension (an strace reveals that it is
   trying to load e.g. greekalpha.xbm.png).  A trawl through the KDE2
   source code verifies this; kiconloader.cpp will react badly to icon
   names that do not end in .xpm or .png.
   SOLUTION: Convert the existing .xbm files to .png format and modify the
   relevant source files to use the new icon names.  MathBrowsers.C and
   MathDelimiterDialog.C are the affected files.

   ADDITIONAL: pics/Makefile.am must be updated to reflect the new
   names.  Also, the icon "brelpreq" is a mis-spelling; it should be
   "brelprec".  I have added these fixes.

2) The macro MathIsAlphaFont in math_defs.h has a typo (a bracket is in
   the wrong place).  This causes KLyx to incorrectly identify keys as
   being non-alphabetic, and hence to exit Tex Mode.
   SOLUTION: Change the line
   #define MathIsAlphaFont(x)  ((int)LM_TC_VAR)<=(x && (x)<=(int)LM_TC_TEXTRM)
   to read
   #define MathIsAlphaFont(x)  ((int)LM_TC_VAR<=(x) && (x)<=(int)LM_TC_TEXTRM)


I have created patch files for
src/MathBrowsers.C
src/MathDelimiterDialog.C
src/math_defs.h
pics/Makefile.am

and a set of .png images to replace the .xbm images in pics/

Please could someone let me know what I should do with these?  I suspect
that they should go in to the KDE source, since I don't think the problem
can be Mandrake-specific.

An updated RPM, including these fixes, is available for testing at
http://www2.eng.cam.ac.uk/~mcb30/klyx-2.0-1.1mdk.i686.rpm.  This RPM
should work on a clean Mandrake 7.2 installation.

Michael

[prev in list] [next in list] [prev in thread] [next in thread]