[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    urgent: crashing flash plugin
From:       Dirk Mueller <mueller () kde ! org>
Date:       2001-07-30 9:58:40
[Download RAW message or body]

Hi, 

can anyone who has the malicious GL support in Qt compiled in and 
experiences the Flash crash try undoing this patch: 


kdebase/nsplugins/nsviewer.cpp:

@@ -366,8 +369,13 @@ void NSPluginInstance::destroy()
         _callback = 0;
 
         kdDebug(1431) << "destroy plugin" << endl;
+        NPSavedData *saved = 0;
         if ( _pluginFuncs.destroy )
-            _pluginFuncs.destroy( _npp, 0 );
+            _pluginFuncs.destroy( _npp, &saved );
+        if (saved && saved->len && saved->buf)
+          g_NPN_MemFree(saved->buf);
+        if (saved)
+          g_NPN_MemFree(saved);          


if this fixes the crash, then please commit it before release. I don't care 
what page gets broken by this, but at least it doesn't crash each and every 
time. 


Dirk

[prev in list] [next in list] [prev in thread] [next in thread]