[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: urgent: crashing flash plugin
From:       Kurt Granroth <granroth () suse ! com>
Date:       2001-07-30 17:50:34
[Download RAW message or body]

On Monday 30 July 2001 02:58 am, Dirk Mueller wrote:
> can anyone who has the malicious GL support in Qt compiled in and
> experiences the Flash crash try undoing this patch:

> @@ -366,8 +369,13 @@ void NSPluginInstance::destroy()
>          _callback = 0;
>
>          kdDebug(1431) << "destroy plugin" << endl;
> +        NPSavedData *saved = 0;
>          if ( _pluginFuncs.destroy )
> -            _pluginFuncs.destroy( _npp, 0 );
> +            _pluginFuncs.destroy( _npp, &saved );
> +        if (saved && saved->len && saved->buf)
> +          g_NPN_MemFree(saved->buf);
> +        if (saved)
> +          g_NPN_MemFree(saved);
>
>
> if this fixes the crash, then please commit it before release. I don't care
> what page gets broken by this, but at least it doesn't crash each and every
> time.

That doesn't go far enough.. or at least it doesn't target the right line.  
The crash happens (on my Suse 7.2 system) in the _pluginFuncs.destroy(_npp) 
line no matter what parameters are passed.  So passing 0 instead of &saved 
doesn't help.

The only solution I could find is to just not call that function right now.  
It will result in a memory leak (no clue offhand how big of one).. but it 
doesn't crash.

Hmm.. is there a way to tell if GL is being used?  Maybe we could do 
something like:

  #if USING_OPENGL
    // leak huge amounts of memory
  #else
    _pluginFuncs.destroy...
-- 
Kurt Granroth            | http://www.granroth.org
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
            KDE -- Conquer Your Desktop

[prev in list] [next in list] [prev in thread] [next in thread]