[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129719: Dolphin: extend availability of "Open Path in New Tab" functionality
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-01-01 18:57:36
Message-ID: 20170101185736.26347.70636 () mimi ! kde ! org
[Download RAW message or body]
--===============9082752721115192550==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129719/#review101708
-----------------------------------------------------------
src/dolphinmainwindow.cpp (line 1173)
<https://git.reviewboard.kde.org/r/129719/#comment68107>
Adding the same action twice should be avoided, adjust the text instead if \
required.
- Emmanuel Pescosta
On Dec. 29, 2016, 3:45 a.m., Don Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129719/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2016, 3:45 a.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This patch converts the "Open Path in New Tab" function to a global action and adds \
> a context menu item for when multiple items are selected in the search view. This \
> allows the function to be accessed via the toolbar(accessible outside of search \
> context) and works on a selection.
>
> Diffs
> -----
>
> src/dolphincontextmenu.h f67300d
> src/dolphincontextmenu.cpp ed3f643
> src/dolphinmainwindow.h 7003e94
> src/dolphinmainwindow.cpp e5103fd
>
> Diff: https://git.reviewboard.kde.org/r/129719/diff/
>
>
> Testing
> -------
>
> manual testing of single/multiple selection via context menu and toolbar
> make test passes
>
>
> File Attachments
> ----------------
>
> Open Path in New Tabs
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/29/8dac26f7-aab3-4e78-87b3-cbe522c7d890__parentstabs.png
>
>
> Thanks,
>
> Don Nguyen
>
>
--===============9082752721115192550==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129719/">https://git.reviewboard.kde.org/r/129719/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129719/diff/1/?file=488217#file488217line1177" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/dolphinmainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1173</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QAction</span><span class="o">*</span> <span \
class="n">openPathInNewTabs</span> <span class="o">=</span> <span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">addAction</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"open_parent_in_new_tabs"</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding the same action \
twice should be avoided, adjust the text instead if required.</pre> </div>
</div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On December 29th, 2016, 3:45 a.m. CET, Don Nguyen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Don Nguyen.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2016, 3:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch converts the "Open Path in New Tab" function to a \
global action and adds a context menu item for when multiple items are selected in \
the search view. This allows the function to be accessed via the toolbar(accessible \
outside of search context) and works on a selection.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">manual testing of single/multiple selection via context menu and toolbar \
make test passes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphincontextmenu.h <span style="color: grey">(f67300d)</span></li>
<li>src/dolphincontextmenu.cpp <span style="color: grey">(ed3f643)</span></li>
<li>src/dolphinmainwindow.h <span style="color: grey">(7003e94)</span></li>
<li>src/dolphinmainwindow.cpp <span style="color: grey">(e5103fd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129719/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/29/8dac26f7-aab3-4e78-87b3-cbe522c7d890__parentstabs.png">Open \
Path in New Tabs</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9082752721115192550==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic