[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129705: [DolphinViewContainer] Show search view only if it's enabled
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-01-01 18:47:18
Message-ID: 20170101184718.26347.68581 () mimi ! kde ! org
[Download RAW message or body]
--===============0630578300489388052==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 1, 2017, 10:36 a.m., Anthony Fieroni wrote:
> > ping
Thanks for the patch and sorry for the late reply!
I think a better approach would be to override the hideEvent method in \
DolphinSearchBox. The hideEvent should just stop the timer.
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129705/#review101692
-----------------------------------------------------------
On Dec. 26, 2016, 2:20 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129705/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2016, 2:20 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> SearchBox request for searching after 1 sec, if url is changed before that time \
> search view is showed again, which is annoying.
>
> Diffs
> -----
>
> src/dolphinviewcontainer.cpp 4e625c7d8
>
> Diff: https://git.reviewboard.kde.org/r/129705/diff/
>
>
> Testing
> -------
>
> Steps to reproduce:
> 1. Type in searchbox
> 2. Quick, before 1 sec timeout is reached, ckick in link in PanelFolder to change \
> the url 3. Timeout is reached, search view is showed again, it's not desired.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============0630578300489388052==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129705/">https://git.reviewboard.kde.org/r/129705/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 1st, 2017, 10:36 a.m. CET, <b>Anthony \
Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ping</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch and \
sorry for the late reply!
I think a better approach would be to override the hideEvent method in \
DolphinSearchBox. The hideEvent should just stop the timer.</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On December 26th, 2016, 2:20 p.m. CET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2016, 2:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">SearchBox request for searching after 1 sec, if url is \
changed before that time search view is showed again, which is annoying.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Steps to reproduce: 1. Type in searchbox
2. Quick, before 1 sec timeout is reached, ckick in link in PanelFolder to change the \
url 3. Timeout is reached, search view is showed again, it's not desired.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinviewcontainer.cpp <span style="color: grey">(4e625c7d8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129705/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0630578300489388052==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic