[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 129712: Properly disable create_dir action
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2017-01-01 18:59:12
Message-ID: 20170101185912.26347.6559 () mimi ! kde ! org
[Download RAW message or body]
--===============7808576547690814736==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129712/#review101709
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On Dec. 28, 2016, 3:38 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129712/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2016, 3:38 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> `isFolderWritable` is set in DolphinView::updateWritableState according to \
> KFileItemListProperties::supportsWriting(). However, `writing=true` does not imply \
> `makedir=true`, in an ioslave's .protocol file. An example is the trash protocol.
> So we need to enable the create_dir action only if the protocol is actually able to \
> create folders.
> CCBUG: 332463
>
>
> Diffs
> -----
>
> src/views/dolphinviewactionhandler.cpp 858f9299b
>
> Diff: https://git.reviewboard.kde.org/r/129712/diff/
>
>
> Testing
> -------
>
> Go to Trash and press F10 with and without patch.
>
> Note that the create_dir action is already disabled by KIO (you can check by \
> showing the menubar and opening File -> Create New menu), yet it was still \
> listening for shortcuts on the Dolphin side.
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============7808576547690814736==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129712/">https://git.reviewboard.kde.org/r/129712/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On December 28th, 2016, 3:38 p.m. CET, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and Emmanuel Pescosta.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2016, 3:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">isFolderWritable</code> is set in DolphinView::updateWritableState \
according to KFileItemListProperties::supportsWriting(). However, <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">writing=true</code> does not imply <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">makedir=true</code>, in an ioslave's .protocol file. An \
example is the trash protocol.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So we need to enable \
the create_dir action only if the protocol is actually able to create folders.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">CCBUG: 332463</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Go to Trash and press F10 with and without patch.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note that the create_dir action is already disabled by \
KIO (you can check by showing the menubar and opening File -> Create New menu), \
yet it was still listening for shortcuts on the Dolphin side.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/views/dolphinviewactionhandler.cpp <span style="color: \
grey">(858f9299b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129712/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7808576547690814736==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic