[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 110970: Use Tab to switch between views
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2016-09-04 12:13:05
Message-ID: 20160904121305.21849.33732 () mimi ! kde ! org
[Download RAW message or body]
--===============5140356037925013221==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110970/
-----------------------------------------------------------
(Updated Sept. 4, 2016, 12:13 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Changes
-------
Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin T. H. \
Sandsmark to branch master.
Bugs: 171743
http://bugs.kde.org/show_bug.cgi?id=171743
Repository: kde-baseapps
Description
-------
Use the Tab key to switch between views. It may be a bit worrying the way the Tab key \
is spied on, but it means it is still possible to use Tab and Shift-Tab to navigate \
other areas of the application. For example, pressing Shift-Tab while a view is \
focused places the focus on the last element of the url navigator. From there, one \
can use Shift-Tab and Tab to focus different elements of the navigator. Pressing Tab \
while on the last element of the navigator puts the focus back on the view.
Diffs
-----
dolphin/src/dolphinmainwindow.cpp 73001bf54e957c967b8203fc06af7556005f8d12
dolphin/src/views/dolphinview.h d77a3a19806cbe8b1ecc1349b82009ef4c3db826
dolphin/src/views/dolphinview.cpp 16b92801be73f6a299dff96c0a6c7506f03f6b42
Diff: https://git.reviewboard.kde.org/r/110970/diff/
Testing
-------
Tested in single and splitted view. I noticed a few glitches, which you may or may \
not consider blockers:
- When the filter widget is visible, it cannot be focused by pressing tab anymore. It \
is still nevertheless possible to focus it with Ctrl+I or its access key.
- Same thing with the find widget. Still focusable with Ctrl+F.
- When one creates a new tab, the current view is not focused, so pressing "Tab" does \
not move the focus to the other view. I have the feeling this is independent from the \
patch and could be fixed y setting the focus to the view when a new tab is created.
Thanks,
Aurélien Gâteau
--===============5140356037925013221==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110970/">https://git.reviewboard.kde.org/r/110970/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2016, 12:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin \
T. H. Sandsmark to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=171743">171743</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the Tab key to switch between views. It may be a bit worrying the \
way the Tab key is spied on, but it means it is still possible to use Tab and \
Shift-Tab to navigate other areas of the application. For example, pressing Shift-Tab \
while a view is focused places the focus on the last element of the url navigator. \
From there, one can use Shift-Tab and Tab to focus different elements of the \
navigator. Pressing Tab while on the last element of the navigator puts the focus \
back on the view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in single and splitted view. I noticed a few glitches, which you \
may or may not consider blockers:
- When the filter widget is visible, it cannot be focused by pressing tab anymore. It \
is still nevertheless possible to focus it with Ctrl+I or its access key.
- Same thing with the find widget. Still focusable with Ctrl+F.
- When one creates a new tab, the current view is not focused, so pressing \
"Tab" does not move the focus to the other view. I have the feeling this is \
independent from the patch and could be fixed y setting the focus to the view when a \
new tab is created.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(73001bf54e957c967b8203fc06af7556005f8d12)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: \
grey">(d77a3a19806cbe8b1ecc1349b82009ef4c3db826)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(16b92801be73f6a299dff96c0a6c7506f03f6b42)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5140356037925013221==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic