'Re: Review Request 128564: Allow using tab for switching between active splits'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 128564: Allow using tab for switching between active splits
From:       Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date:       2016-09-04 12:13:05
Message-ID: 20160904121305.25909.824 () mimi ! kde ! org
[Download RAW message or body]

--===============5209299089243256198==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128564/
-----------------------------------------------------------

(Updated Sept. 4, 2016, 2:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin, Elvis Angelaccio, Emmanuel Pescosta, and Aurélien \
Gâteau.


Changes
-------

Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin T. H. \
Sandsmark to branch master.


Bugs: 171743
    https://bugs.kde.org/show_bug.cgi?id=171743


Repository: dolphin


Description
-------

Based on https://git.reviewboard.kde.org/r/110970/, but with a setting for \
enabling/disabling.

The problem with focus doesn't seem to exist anymore.


Diffs
-----

  src/dolphintabpage.h b46daf3 
  src/dolphintabpage.cpp 0382341 
  src/settings/dolphin_generalsettings.kcfg 12f1585 
  src/settings/general/behaviorsettingspage.h 6213734 
  src/settings/general/behaviorsettingspage.cpp 86a4ad3 
  src/views/dolphinview.h d1a5d50 
  src/views/dolphinview.cpp 5466fd3 

Diff: https://git.reviewboard.kde.org/r/128564/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark


--===============5209299089243256198==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128564/">https://git.reviewboard.kde.org/r/128564/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin, Elvis Angelaccio, Emmanuel Pescosta, and Aurélien \
Gâteau.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>


<p style="color: grey;"><i>Updated Sept. 4, 2016, 2:13 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin \
T. H. Sandsmark to branch master.</pre>  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=171743">171743</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Based on https://git.reviewboard.kde.org/r/110970/, \
but with a setting for enabling/disabling.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem with focus \
doesn't seem to exist anymore.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dolphintabpage.h <span style="color: grey">(b46daf3)</span></li>

 <li>src/dolphintabpage.cpp <span style="color: grey">(0382341)</span></li>

 <li>src/settings/dolphin_generalsettings.kcfg <span style="color: \
grey">(12f1585)</span></li>

 <li>src/settings/general/behaviorsettingspage.h <span style="color: \
grey">(6213734)</span></li>

 <li>src/settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(86a4ad3)</span></li>

 <li>src/views/dolphinview.h <span style="color: grey">(d1a5d50)</span></li>

 <li>src/views/dolphinview.cpp <span style="color: grey">(5466fd3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128564/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============5209299089243256198==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic