From kfm-devel Sun Sep 04 12:13:05 2016 From: =?utf-8?b?QXVyw6lsaWVuIEfDonRlYXU=?= Date: Sun, 04 Sep 2016 12:13:05 +0000 To: kfm-devel Subject: Re: Review Request 110970: Use Tab to switch between views Message-Id: <20160904121305.21849.33732 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=147299119208891 --===============5140356037925013221== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110970/ ----------------------------------------------------------- (Updated Sept. 4, 2016, 12:13 p.m.) Status ------ This change has been marked as submitted. Review request for Dolphin. Changes ------- Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin T. H. Sandsmark to branch master. Bugs: 171743 http://bugs.kde.org/show_bug.cgi?id=171743 Repository: kde-baseapps Description ------- Use the Tab key to switch between views. It may be a bit worrying the way the Tab key is spied on, but it means it is still possible to use Tab and Shift-Tab to navigate other areas of the application. For example, pressing Shift-Tab while a view is focused places the focus on the last element of the url navigator. From there, one can use Shift-Tab and Tab to focus different elements of the navigator. Pressing Tab while on the last element of the navigator puts the focus back on the view. Diffs ----- dolphin/src/dolphinmainwindow.cpp 73001bf54e957c967b8203fc06af7556005f8d12 dolphin/src/views/dolphinview.h d77a3a19806cbe8b1ecc1349b82009ef4c3db826 dolphin/src/views/dolphinview.cpp 16b92801be73f6a299dff96c0a6c7506f03f6b42 Diff: https://git.reviewboard.kde.org/r/110970/diff/ Testing ------- Tested in single and splitted view. I noticed a few glitches, which you may or may not consider blockers: - When the filter widget is visible, it cannot be focused by pressing tab anymore. It is still nevertheless possible to focus it with Ctrl+I or its access key. - Same thing with the find widget. Still focusable with Ctrl+F. - When one creates a new tab, the current view is not focused, so pressing "Tab" does not move the focus to the other view. I have the feeling this is independent from the patch and could be fixed y setting the focus to the view when a new tab is created. Thanks, Aurélien Gâteau --===============5140356037925013221== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110970/

This change has been marked as submitted.

Review request for Dolphin.
By Aurélien Gâteau.

Updated Sept. 4, 2016, 12:13 p.m.

Changes

Submitted with commit b706108206be1c9e777e1ace02aa99247fdfc3ca by Martin T. H. Sandsmark to branch master.
Bugs: 171743
Repository: kde-baseapps

Description 

Use the Tab key to switch between views. It may be a bit worrying the way the Tab key is spied on, but it means it is still possible to use Tab and Shift-Tab to navigate other areas of the application. For example, pressing Shift-Tab while a view is focused places the focus on the last element of the url navigator. From there, one can use Shift-Tab and Tab to focus different elements of the navigator. Pressing Tab while on the last element of the navigator puts the focus back on the view.

Testing 

Tested in single and splitted view. I noticed a few glitches, which you may or may not consider blockers:

- When the filter widget is visible, it cannot be focused by pressing tab anymore. It is still nevertheless possible to focus it with Ctrl+I or its access key.

- Same thing with the find widget. Still focusable with Ctrl+F.

- When one creates a new tab, the current view is not focused, so pressing "Tab" does not move the focus to the other view. I have the feeling this is independent from the patch and could be fixed y setting the focus to the view when a new tab is created.

Diffs

  • dolphin/src/dolphinmainwindow.cpp (73001bf54e957c967b8203fc06af7556005f8d12)
  • dolphin/src/views/dolphinview.h (d77a3a19806cbe8b1ecc1349b82009ef4c3db826)
  • dolphin/src/views/dolphinview.cpp (16b92801be73f6a299dff96c0a6c7506f03f6b42)

View Diff
--===============5140356037925013221==--