'Re: Review Request 127034: Close tab on mouse release'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request 127034: Close tab on mouse release
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2016-02-10 21:52:54
Message-ID: 20160210215254.21781.51026 () mimi ! kde ! org
[Download RAW message or body]

--===============1840011969119004953==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127034/#review92244
-----------------------------------------------------------



Makes sense, but I'm wondering if we should check if the tab where the button is \
released is also the one where the button was pressed. Other apps seem to do this \
(i.e., they do not close a tab if you middle-click somewhere outside the tab, move \
the mouse to the tab, and then release).

- Frank Reininghaus


On Feb. 10, 2016, 9:38 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127034/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 9:38 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> rather than on mouse press.
> 
> 
> Diffs
> -----
> 
> src/dolphintabbar.h 6daa9a1 
> src/dolphintabbar.cpp dbd324d 
> 
> Diff: https://git.reviewboard.kde.org/r/127034/diff/
> 
> 
> Testing
> -------
> 
> I've always wondered why closing tabs in Dolphin felt so weird compared to other \
> applications, now I know why. 
> Makes it consistent with other applications, namely web browsers, also button \
> presses are also usually handled on release. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 


--===============1840011969119004953==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127034/">https://git.reviewboard.kde.org/r/127034/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes \
sense, but I'm wondering if we should check if the tab where the button is released \
is also the one where the button was pressed. Other apps seem to do this (i.e., they \
do not close a tab if you middle-click somewhere outside the tab, move the mouse to \
the tab, and then release).</p></pre>  <br />









<p>- Frank Reininghaus</p>


<br />
<p>On February 10th, 2016, 9:38 p.m. UTC, Kai Uwe Broulik wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Feb. 10, 2016, 9:38 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">rather than on mouse press.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've always wondered why closing tabs in Dolphin felt \
so weird compared to other applications, now I know why.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes \
it consistent with other applications, namely web browsers, also button presses are \
also usually handled on release.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dolphintabbar.h <span style="color: grey">(6daa9a1)</span></li>

 <li>src/dolphintabbar.cpp <span style="color: grey">(dbd324d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127034/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1840011969119004953==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic