From kfm-devel Wed Feb 10 21:52:54 2016 From: Frank Reininghaus Date: Wed, 10 Feb 2016 21:52:54 +0000 To: kfm-devel Subject: Re: Review Request 127034: Close tab on mouse release Message-Id: <20160210215254.21781.51026 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=145514119504876 --===============1840011969119004953== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127034/#review92244 ----------------------------------------------------------- Makes sense, but I'm wondering if we should check if the tab where the button is released is also the one where the button was pressed. Other apps seem to do this (i.e., they do not close a tab if you middle-click somewhere outside the tab, move the mouse to the tab, and then release). - Frank Reininghaus On Feb. 10, 2016, 9:38 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127034/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 9:38 p.m.) > > > Review request for Dolphin and KDE Usability. > > > Repository: dolphin > > > Description > ------- > > rather than on mouse press. > > > Diffs > ----- > > src/dolphintabbar.h 6daa9a1 > src/dolphintabbar.cpp dbd324d > > Diff: https://git.reviewboard.kde.org/r/127034/diff/ > > > Testing > ------- > > I've always wondered why closing tabs in Dolphin felt so weird compared to other applications, now I know why. > > Makes it consistent with other applications, namely web browsers, also button presses are also usually handled on release. > > > Thanks, > > Kai Uwe Broulik > > --===============1840011969119004953== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127034/

Makes sense, but I'm wondering if we should check if the tab where the button is released is also the one where the button was pressed. Other apps seem to do this (i.e., they do not close a tab if you middle-click somewhere outside the tab, move the mouse to the tab, and then release).

- Frank Reininghaus

On February 10th, 2016, 9:38 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Dolphin and KDE Usability.

By Kai Uwe Broulik.

Updated Feb. 10, 2016, 9:38 p.m.

Repository: dolphin

Description

rather than on mouse press.

Testing

I've always wondered why closing tabs in Dolphin felt so weird compared to other applications, now I know why.

Makes it consistent with other applications, namely web browsers, also button presses are also usually handled on release.

Diffs

src/dolphintabbar.h (6daa9a1)
src/dolphintabbar.cpp (dbd324d)

View Diff

--===============1840011969119004953==--