[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 126927: Support KFileMetadata OriginUrl as "Downloaded From"
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-02-10 21:46:03
Message-ID: 20160210214603.23891.81181 () mimi ! kde ! org
[Download RAW message or body]
--===============3703180723420647269==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 10, 2016, 9:45 nachm., Frank Reininghaus wrote:
> > Note that this makes Dolphin require a newer KF5 version than before. I've just \
> > increased the required version to 5.19, such that it fails at CMake stage, and \
> > not during compilation, if the installed KF5 version is too old: \
> > https://quickgit.kde.org/?p=dolphin.git&a=commit&h=6c5930c229c8b96aae45e19ad4b7a1c57caa6ddc
> >
Right. Sorry, I always forget this.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126927/#review92242
-----------------------------------------------------------
On Feb. 9, 2016, 9:11 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126927/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:11 nachm.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This brings back the functionality to show where a file originally was downloaded \
> from using xattr originUrl.
>
> Diffs
> -----
>
> src/kitemviews/kfileitemmodel.h 167f508
> src/kitemviews/kfileitemmodel.cpp 5f6fed0
> src/kitemviews/private/kbaloorolesprovider.cpp 920ce06
>
> Diff: https://git.reviewboard.kde.org/r/126927/diff/
>
>
> Testing
> -------
>
> I wanted to make the column shown by default when in the downloads folder and in \
> column view but failed.
> Also, Dolphin doesn't seem to enforce a maximum column width, so your view suddenly \
> scrolls horizontally for kilometers as URLs can get quite long.
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/30/9f5c6e4c-93d5-4256-866e-44ec74133d55__Screenshot_20160130_202825.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============3703180723420647269==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126927/">https://git.reviewboard.kde.org/r/126927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Februar 10th, 2016, 9:45 nachm. UTC, <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note that this makes Dolphin require a newer KF5 \
version than before. I've just increased the required version to 5.19, such that it \
fails at CMake stage, and not during compilation, if the installed KF5 version is too \
old: https://quickgit.kde.org/?p=dolphin.git&a=commit&h=6c5930c229c8b96aae45e19ad4b7a1c57caa6ddc</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right. Sorry, I always forget this.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Februar 9th, 2016, 9:11 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2016, 9:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This brings back the functionality to show where a \
file originally was downloaded from using xattr originUrl.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I wanted to make the column shown by default when in \
the downloads folder and in column view but failed.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, \
Dolphin doesn't seem to enforce a maximum column width, so your view suddenly scrolls \
horizontally for kilometers as URLs can get quite long.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kitemviews/kfileitemmodel.h <span style="color: grey">(167f508)</span></li>
<li>src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(5f6fed0)</span></li>
<li>src/kitemviews/private/kbaloorolesprovider.cpp <span style="color: \
grey">(920ce06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126927/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/30/9f5c6e4c \
-93d5-4256-866e-44ec74133d55__Screenshot_20160130_202825.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3703180723420647269==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic