[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 114957: Add support for getting a samba share's total size and free space through
From: "Mathias Tillman" <master.homer () gmail ! com>
Date: 2014-09-14 16:57:30
Message-ID: 20140914165730.22584.29484 () probe ! kde ! org
[Download RAW message or body]
--===============0078961669379220426==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/
-----------------------------------------------------------
(Updated Sept. 14, 2014, 4:57 p.m.)
Status
------
This change has been discarded.
Review request for Dolphin and David Faure.
Bugs: 245226
http://bugs.kde.org/show_bug.cgi?id=245226
Repository: kde-baseapps
Description
-------
Added support for getting a samba share's total size and the current free space \
through a special KIO command. This is the dolphin part of the code, see #114956 for \
the other part.
Diffs
-----
dolphin/src/statusbar/statusbarspaceinfo.h 1849462
dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833
Diff: https://git.reviewboard.kde.org/r/114957/diff/
Testing
-------
I have tried browsing samba shares. I have not, however, done a lot of error checking \
(network down etc). But the code should be ready for that.
Thanks,
Mathias Tillman
--===============0078961669379220426==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114957/">https://git.reviewboard.kde.org/r/114957/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and David Faure.</div>
<div>By Mathias Tillman.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 4:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=245226">245226</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added support for getting a samba share's total size and the current \
free space through a special KIO command. This is the dolphin part of the code, see \
#114956 for the other part.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tried browsing samba shares. I have not, however, done a lot of \
error checking (network down etc). But the code should be ready for that.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/statusbar/statusbarspaceinfo.h <span style="color: \
grey">(1849462)</span></li>
<li>dolphin/src/statusbar/statusbarspaceinfo.cpp <span style="color: \
grey">(61b2833)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114957/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0078961669379220426==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic