[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 120137: Add new KIO job that let's you get a drive's size (smb or local for now),
From: "Mathias Tillman" <master.homer () gmail ! com>
Date: 2014-09-14 16:54:44
Message-ID: 20140914165444.22584.22717 () probe ! kde ! org
[Download RAW message or body]
--===============1454404630151541172==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120137/
-----------------------------------------------------------
(Updated Sept. 14, 2014, 4:54 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin and David Faure.
Bugs: 245226
http://bugs.kde.org/show_bug.cgi?id=245226
Repository: kde-baseapps
Description
-------
This patch adds support for the new driveSize job used for the status bar space info.
This is a follow up to : https://git.reviewboard.kde.org/r/114956/ and \
https://git.reviewboard.kde.org/r/114957/.
Diffs
-----
dolphin/src/statusbar/mountpointobserver.h ac5f8ecc37391ff589d2f26e459e8ab625084b6a \
dolphin/src/statusbar/mountpointobserver.cpp \
4a23be6b621320f086464c1e7cee04854a78392f \
dolphin/src/statusbar/mountpointobservercache.h \
425000645b7eb4b90aafca6fef8d62f3292e53a4 \
dolphin/src/statusbar/mountpointobservercache.cpp \
aff0c8e2f051737ab9e8544107e3f12eb3c7a665 dolphin/src/statusbar/spaceinfoobserver.h \
d2fb6ebf31ad88ae7b233ebffb00c1ef48db4359 \
dolphin/src/statusbar/spaceinfoobserver.cpp 9125a9308a51fc8f406f12d931f7380e06e8f5e9 \
dolphin/src/statusbar/statusbarspaceinfo.cpp ea8b4704c02f6a9ed9e14d15882081fadbefffe4 \
Diff: https://git.reviewboard.kde.org/r/120137/diff/
Testing
-------
I've tried browsing around normally in dolphin, both in local drives and in samba \
shares.
Thanks,
Mathias Tillman
--===============1454404630151541172==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120137/">https://git.reviewboard.kde.org/r/120137/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and David Faure.</div>
<div>By Mathias Tillman.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 4:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=245226">245226</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds support for the new driveSize job used \
for the status bar space info.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a follow up to \
: https://git.reviewboard.kde.org/r/114956/ and \
https://git.reviewboard.kde.org/r/114957/.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've tried browsing around normally in dolphin, both \
in local drives and in samba shares.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/statusbar/mountpointobserver.h <span style="color: \
grey">(ac5f8ecc37391ff589d2f26e459e8ab625084b6a)</span></li>
<li>dolphin/src/statusbar/mountpointobserver.cpp <span style="color: \
grey">(4a23be6b621320f086464c1e7cee04854a78392f)</span></li>
<li>dolphin/src/statusbar/mountpointobservercache.h <span style="color: \
grey">(425000645b7eb4b90aafca6fef8d62f3292e53a4)</span></li>
<li>dolphin/src/statusbar/mountpointobservercache.cpp <span style="color: \
grey">(aff0c8e2f051737ab9e8544107e3f12eb3c7a665)</span></li>
<li>dolphin/src/statusbar/spaceinfoobserver.h <span style="color: \
grey">(d2fb6ebf31ad88ae7b233ebffb00c1ef48db4359)</span></li>
<li>dolphin/src/statusbar/spaceinfoobserver.cpp <span style="color: \
grey">(9125a9308a51fc8f406f12d931f7380e06e8f5e9)</span></li>
<li>dolphin/src/statusbar/statusbarspaceinfo.cpp <span style="color: \
grey">(ea8b4704c02f6a9ed9e14d15882081fadbefffe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120137/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1454404630151541172==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic