[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 120194: Ported Dolphin away from KStandardDirs
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2014-09-14 20:02:10
Message-ID: 20140914200210.22585.26339 () probe ! kde ! org
[Download RAW message or body]
--===============5820650033679525614==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120194/#review66494
-----------------------------------------------------------
dolphin/src/settings/services/servicessettingspage.cpp
<https://git.reviewboard.kde.org/r/120194/#comment46358>
this is usually $prefix/share/kservices5
- Hrvoje Senjan
On Sept. 14, 2014, 11:27 a.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120194/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2014, 11:27 a.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> * Ported Dolphin away from KStandardDirs
> * removed unused mirroredDirectory method
>
>
> Diffs
> -----
>
> dolphin/src/dolphincontextmenu.cpp e74adca
> dolphin/src/dolphinmainwindow.cpp 5e5eeb0
> dolphin/src/panels/places/placesitemmodel.cpp 8eb79a8
> dolphin/src/settings/services/servicessettingspage.cpp 78a865d
> dolphin/src/settings/viewpropertiesdialog.cpp 41a39f2
> dolphin/src/views/viewproperties.h 69b507f
> dolphin/src/views/viewproperties.cpp bcea062
>
> Diff: https://git.reviewboard.kde.org/r/120194/diff/
>
>
> Testing
> -------
>
> Works. View mode settings of read only folders are stored properly.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============5820650033679525614==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120194/">https://git.reviewboard.kde.org/r/120194/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120194/diff/1/?file=312106#file312106line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/settings/services/servicessettingspage.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ServicesSettingsPage::loadServices()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">198</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">file</span> \
<span class="o">=</span> <span class="n"><span class="hl">K</span>Standard<span \
class="hl">Dir</span>s</span><span class="o">::</span><span \
class="n">locate</span><span class="p">(</span><span class="s"><span \
class="hl">"</span>services<span class="hl">"</span></span><span \
class="p"><span class="hl">,</span></span> <span class="n">service</span><span \
class="o">-></span><span class="n">entryPath</span><span \
class="p">());</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">198</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span \
class="n">QString</span> <span class="n">file</span> <span class="o">=</span> <span \
class="n"><span class="hl">Q</span>Standard<span class="hl">Path</span>s</span><span \
class="o">::</span><span class="n">locate</span><span class="p">(</span><span \
class="n"><span class="hl">QStandardPaths</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">GenericDataLocation</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="s"><span \
class="hl">"kde5/</span>services<span class="hl">/"</span></span><span \
class="hl"> </span><span class="o"><span class="hl">%</span></span> <span \
class="n">service</span><span class="o">-></span><span \
class="n">entryPath</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
is usually $prefix/share/kservices5</p></pre> </div>
</div>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On September 14th, 2014, 11:27 a.m. CEST, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 11:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Ported Dolphin away from \
KStandardDirs</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">removed unused mirroredDirectory \
method</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works. View mode settings of read only folders are \
stored properly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(e74adca)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(5e5eeb0)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(8eb79a8)</span></li>
<li>dolphin/src/settings/services/servicessettingspage.cpp <span style="color: \
grey">(78a865d)</span></li>
<li>dolphin/src/settings/viewpropertiesdialog.cpp <span style="color: \
grey">(41a39f2)</span></li>
<li>dolphin/src/views/viewproperties.h <span style="color: \
grey">(69b507f)</span></li>
<li>dolphin/src/views/viewproperties.cpp <span style="color: \
grey">(bcea062)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120194/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5820650033679525614==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic