[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Dolphin and Baloo
From:       Vishesh Handa <me () vhanda ! in>
Date:       2014-01-28 10:09:39
Message-ID: 2785577.PiRuHOvoKz () vlap
[Download RAW message or body]

On Monday 27 January 2014 18:16:09 Emmanuel Pescosta wrote:
> /dolphin/src/kitemviews/private/kbaloorolesprovider.cpp:
> line 76 - 79: Please add {} brackets

Fixed

> line 82: Maybe make use of string builder!?
> 

Fixed

> /dolphin/src/search/dolphinsearchinformation.cpp:
> line 75: Rename it "strigiConfig" to "balooConfig" or "config"
> 

Fixed

> /dolphin/src/search/dolphinsearchbox.cpp:
> line 437: brackets
> 

Fixed

> The rest looks pretty good ;)
> 
> +1 from my side
>  

Thanks!

-- 
Vishesh Handa
[prev in list] [next in list] [prev in thread] [next in thread]